[Bug 507223] Review Request: dalston - Moblin System Information Icons

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507223


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #40 from Christoph Wickert <cwickert at fedoraproject.org>  2009-10-06 20:25:12 EDT ---
(In reply to comment #38)
> Umm.... from the top of the spec file:

Well, if you want this package reviewed ASAP, then you should make notice of
the fact that you changes Source0 in order to fix the autotools mismatch. I
thought we were still waiting for something all the time.

(In reply to comment #39)
> I don't see that there's anything else to do.  

The gtk-update-icon-cache stuff still is wrong. It is only needed when a
package puts icons into gtk's icon search path [1], this means into
/usr/share/icons. %{_datadir}/dalston/icons is a private location, nothing
except dalston will ever look there. Just drop the scriptlets.

I don't see any blockers left, so the package is finally APPROVED.


[1] http://standards.freedesktop.org/icon-theme-spec/latest/ar01s03.html
    http://standards.freedesktop.org/icon-theme-spec/latest/ar01s05.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.