[Bug 523601] Review Request: swish-e - Simple Web Indexing System for Humans - Enhanced

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523601





--- Comment #3 from Ionuț Arțăriși <mapleoin at fedoraproject.org>  2009-10-07 11:55:19 EDT ---
> [rakesh at dhcp1-96 SPECS]$ rpmlint swish-e.spec
> swish-e.spec:92: E: hardcoded-library-path in %{_prefix}/lib/swish-e/*cgi
> swish-e.spec:94: E: hardcoded-library-path in
> %{_prefix}/lib/swish-e/swishspider
> swish-e.spec:95: E: hardcoded-library-path in %{_prefix}/lib/swish-e/*pl
> 0 packages and 1 specfiles checked; 3 errors, 0 warnings.
> Ignore all of them .. I cannot find any macro which specially expands to
> /usr/lib/ on 64bit and not to /usr/lib64/

Strangely, it seems that the configure sets a hardcoded library path of /lib 
and your hardcoding actually counters that, so it's ok.


> file-not-utf8 please ignore this one as some names are in not utf-8 and
> changing them would make sense either.

I skimmed the text in those files and failed to find any non-utf-8
characters. The problem with those files is that they're in the old iso-8859-1
charset (as `file -i` reveals). Converting them to UTF-8 is painless:
https://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8


Please don't mix macros styles:
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS


These errors also require changed permissions
https://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang

perl-SWISH.x86_64: E: script-without-shebang
/usr/lib/perl5/vendor_perl/5.10.0/SWISH/Filter.pm
perl-SWISH.x86_64: E: script-without-shebang
/usr/lib/perl5/vendor_perl/5.10.0/SWISH/TemplateFrame.pm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.