[Bug 524379] Review Request: gscribble - A desktop blogging client for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524379


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-12 14:26:03 EDT ---
Some notes:

* %define -> %global
  - Now Fedora suggests to use %global instead of %define for
    some reason:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

* Requires
  - Please check the dependency for python module related packages (this
    cannot be detected automatically by rpmbuild and you have to investigate
    this manually by yourself).
    ! Example
      /usr/bin/gscribble contains:
---------------------------------------------------------------------
    16  try:
    17          import pygtk    
    18          pygtk.require('2.0')
    19  except:
    20          print "Install PyGtk >= 2.0."
    21          sys.exit(1)
---------------------------------------------------------------------
      This means that this package should have "Requiers: pygtk2".

* CFLAGS on noarch package
  - If this package is noarch package, setting CFLAGS is not needed.

* Duplicate files
  - Document files are installed under both /usr/share/gscribble/docs/
    and /usr/share/doc/gscribble-0.0.2/. 
    ! Choosing /usr/share/doc/gscribble-0.0.2/ is preferred, however
      please check if files under /usr/share/gscribble/docs/ can really
      be removed.
    ! By the way usually "INSTALL" file is not needed. This file is needed
      for people to compile/install softwares by themselves and not needed
      for people using rpm.

* Some notes for source codes
  - By the way /usr/bin/gscribble contains:
---------------------------------------------------------------------
    31  __project__ = 'GScribble'
    32  __website__ = 'http://sourceforge.net/projects/gscribble'
    33  __version__ = '0.0.1'
    34  __authors__ = ['Roshan Kumar Singh <singh.roshan08 at gmail.com>',]
 ---------------------------------------------------------------------
    But version seems 0.0.2?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.