[Bug 527488] Review Request: drbd - drbd tools

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 13 15:21:02 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #16 from LINBIT <partner at linbit.com>  2009-10-13 11:21:01 EDT ---
Yet another update after Fabio's extremely helpful comments:

http://people.linbit.com/~florian/drbd.spec
http://people.linbit.com/~florian/drbd-8.3.4-5.src.rpm

This is the abbreviated changelog since the last update (most recent commit
first):

ae4d483... drbd.spec.in: remove mkdir -p %{buildroot} during %build
931270d... drbd.spec.in: add defattr for %files section
20b1aa8... drbd.spec.in: bump release number
999bbfc... drbd.spec.in: add conditional build dependency on udev
a43b004... drbd.spec.in: move %configure invocation to %prep stage
789f4e6... configure.ac: set KVER and KDIR only with --with-km is set
89991a5... configure.ac, drbd.spec.in: change default to "--without km"

I have also started doing koji scratch builds for f12 and f13, see task logs
here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1744253
http://koji.fedoraproject.org/koji/taskinfo?taskID=1744268

FYI, rpmlint still reports these errors:

drbd.spec:81: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/outdate-peer.sh
drbd.spec:82: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/snapshot-resync-target-lvm.sh
drbd.spec:83: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/unsnapshot-resync-target-lvm.sh
drbd.spec:84: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-out-of-sync.sh
drbd.spec:85: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-split-brain.sh
drbd.spec:86: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-emergency-reboot.sh
drbd.spec:87: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-emergency-shutdown.sh
drbd.spec:88: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-io-error.sh
drbd.spec:89: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-pri-lost-after-sb.sh
drbd.spec:90: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-pri-lost.sh
drbd.spec:91: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/notify-pri-on-incon-degr.sh
drbd.spec:92: E: hardcoded-library-path in %{_prefix}/lib/%{name}/notify.sh
drbd.spec:183: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/crm-fence-peer.sh
drbd.spec:184: E: hardcoded-library-path in
%{_prefix}/lib/%{name}/crm-unfence-peer.sh

I request an exception for these on the grounds that all of these are simply
integration shell scripts that are exactly identical on 32 and 64 bit
platforms, and it would make positively no sense to install these to either
/usr/lib or /usr/lib64; that would just royally confuse users.

drbd.spec:185: E: hardcoded-library-path in
%{_prefix}/lib/ocf/resource.d/linbit/drbd

I request an exception for this on the grounds that the
%{_prefix}/lib/ocf/resource.d/<provider>/<agent> path is prescribed by the Open
Cluster Framework (OCF) standard.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list