[Bug 521895] Review Request: json_simple - Simple Java toolkit for JSON

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521895


Orion Poplawski <orion at cora.nwra.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |orion at cora.nwra.com
         AssignedTo|nobody at fedoraproject.org    |orion at cora.nwra.com
               Flag|                            |fedora-review+




--- Comment #1 from Orion Poplawski <orion at cora.nwra.com>  2009-10-15 11:18:53 EDT ---
    *  rpmlint - clean (expected warning only)
    * naming - OK
    * NamingGuidelines - OK 
    * licensing - ASL 2.0 - OK - You might mention to upstream that the
copyright and license should be added to each source file.

specfile

    * American English - OK
    * legible - OK
    * BuildRequires - OK
    * Locales - None
    * shared libraries: ldconfig - None
    *  %clean section with rm -rf ${RPM_BUILD_ROOT} - Check
    * sources - md5 sum checks out
    * relocatable? No
    * files and directories - Okay
    * owns all created directories - Yes
    * all files listed in %files - Yes (I prefer explicit listing - catches
changes and problems better, but this is personal preference.)
    * permissions?  Yes
    * deffattr? Yes 
    * no .la files  Check
    * .desktop for GUI applications - NA
    * no conflicts with other packets - Check
    * -devel - NA
    * headers - NA
    * large doc in -doc package - not needed
    * must not affect runtime - Check

Minor issues:

    * macros - You are mixing $RPM_BUILD_ROOT and %{buildroot}
    * doc - I would add AUTHORS.txt and README.txt

Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.