[Bug 527488] Review Request: drbd - drbd tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #32 from LINBIT <partner at linbit.com>  2009-10-15 11:18:19 EDT ---
Here is a listing of rpmlint warnings and errors that Fabio reported:

> drbd.src: W: name-repeated-in-summary DRBD

Well, it's the DRBD driver. What else is there to say? :)

> drbd.src: W: strange-permission drbd.spec 0600

No idea. It's 0640 here. 

> drbd.x86_64: E: no-binary

Yes the drbd metapackage could be flagged as noarch. No it currently can't be
built that way. See comment #21.

drbd-bash-completion.x86_64: W: non-conffile-in-etc
/etc/bash_completion.d/drbdadm

Flagged with %config now.

> drbd-pacemaker.x86_64: W: spurious-executable-perm /usr/share/doc/drbd-pacemaker-8.3.4/COPYING

Fixed.

> drbd-udev.x86_64: W: summary-not-capitalized udev integration scripts for DRBD

Even Wikipedia doesn't capitalize "udev" at the beginning of a sentence.

> drbd-udev.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/65-drbd.rules

Flagged with %config now.

> drbd-utils.x86_64: W: unstripped-binary-or-object /sbin/drbdsetup
> drbd-utils.x86_64: W: unstripped-binary-or-object /sbin/drbdmeta

This one leaves me completely baffled.  AFAICS this is supposed to happen when
building with debuginfo disabled, not building with gcc -g, or when installing
.so files without the x bit set. None of that is the case. I have no idea how
to fix this.

Building and installing, and then examining the installed files, yields this:

file /sbin/drbdmeta /sbin/drbdsetup
/sbin/drbdmeta:  ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for
GNU/Linux 2.6.9, dynamically linked (uses shared libs), for GNU/Linux 2.6.9,
stripped
/sbin/drbdsetup: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for
GNU/Linux 2.6.9, dynamically linked (uses shared libs), for GNU/Linux 2.6.9,
stripped

So, definitely stripped.

And they're not missing from the debuginfo package either:
rpm -qlp drbd-debuginfo-8.3.4-7.x86_64.rpm
/usr/lib/debug
/usr/lib/debug/sbin
/usr/lib/debug/sbin/drbdadm.debug
/usr/lib/debug/sbin/drbdmeta.debug
/usr/lib/debug/sbin/drbdsetup.debug

Either this is an rpmlint bug, or I'm overlooking something obvious.


> drbd-utils.x86_64: W: only-non-binary-in-usr-lib

OK, this refers to helper scripts installing into /usr/lib/drbd. Discussed
previously, it's my understanding that that is OK.

> drbd-utils.x86_64: W: service-default-enabled /etc/rc.d/init.d/drbd
> drbd-utils.x86_64: W: service-default-enabled /etc/rc.d/init.d/drbd

chkconfig headers in the init script have been fixed.

> drbd-xen.x86_64: W: spurious-executable-perm /usr/share/doc/drbd-xen-8.3.4/COPYING

Also fixed to default attributes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.