[Bug 515136] Review Request: gettext-commons - Java internationalization (i18n) library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515136





--- Comment #5 from Mat Booth <fedora at matbooth.co.uk>  2009-10-15 14:36:29 EDT ---
OK, I've gone through the packaging guidelines and the reviewing guidelines...



Please fix the following:

I cannot install the javadoc subpackage because of line 35, which reads:
  Requires:       %{name}-%{version}-%{release}
It should instead read:
  Requires:       %{name} = %{version}-%{release}

You mix $THIS_STYLE and %{this_style} variables, which is bad form so the
guidelines say. You can easily fix this by replacing all instances of
$RPM_BUILD_ROOT with %{buildroot}

This one is your choice, but by convention javadoc is installed into a
versioned directory %{buildroot}%{_javadocdir}/%{name}-%{version} and then an
unversioned symlink is made %{buildroot}%{_javadocdir}/%{name} to the versioned
directory. (Just like you did with the jar file.)



Other points:

Have you sent the javadoc.patch upstream? Seems like one they could accept
easily. If you have sent this upstream, please include a link the bug report in
a comment.



Once you've addressed these points, I'll give it another look and then probably
you're ready to go. Thanks for your submission (and thanks for waiting
patiently for someone to review it)  :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.