[Bug 527996] Review Request: jempbox - Java library for working with XMP metadata

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527996


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #10 from Steve Traylen <steve.traylen at cern.ch>  2009-10-15 17:04:04 EDT ---
Hi Orion,
Speedy.

Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1748214


YES: rpmlint
$ rpmlint SPECS/jempbox.spec RPMS/x86_64/jempbox-0.8.0-5.fc11.x86_64.rpm
RPMS/x86_64/jempbox-debuginfo-0.8.0-5.fc11.x86_64.rpm
SRPMS/jempbox-0.8.0-5.fc11.src.rpm 
SPECS/jempbox.spec:89: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
jempbox.src:89: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
3 packages and 1 specfiles checked; 0 errors, 2 warnings.

which is expected because of the %if case for gcj.

YES: Package name.
YES: Spec file name.
YES: Package guidelines for java.
YES: License clear and good.
YES: License in .spec correct.
YES: LICENSE.txt included.
YES: American English.
YES: Legible.
YES: 
$ md5sum jempbox-0.8.0-incubating-src.jar
../SOURCES/jempbox-0.8.0-incubating-src.jar 
b15d0837cc25b47bbdb0e2a49b8c6b65  jempbox-0.8.0-incubating-src.jar
b15d0837cc25b47bbdb0e2a49b8c6b65  ../SOURCES/jempbox-0.8.0-incubating-src.jar

YES: compiles, see koji above.
YES: compiels on all archs.
YES: BuildRequires good.
YES: no locales present.
YES: ldconfig not needed.
YES: no system libs.
YES: not relocatable.
YES: owns all directories.
YES: No double file entries.
YES: All %defattr
YES: buildroot removed in %clean.
YES: Yes there is code in there.
YES: no large docs.
YES: %doc not needed runtime.
YES: no header files present.
YES: No static libs.
YES: No pkgconfig files.
YES: No devel package.
YES: No .la files.
YES: No gui.
YES: buildroot removed at install.
YES: valid utf8

Voila, APPROVED

Thanks for the review.

Steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.