[Bug 524605] Review Request: gtrayicon - Generic tray icon for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524605





--- Comment #11 from Dominic Hopf <dmaphy at fedoraproject.org>  2009-10-17 08:22:18 EDT ---
$ rpmlint gtrayicon.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint gtrayicon-1.1-1.fc12.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint gtrayicon-1.1-1.fc10.x86_64.rpm
gtrayicon-debuginfo-1.1-1.fc10.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


MUSTs
-----

OK: packaged is named according to the package naming guidelines
OK: specfile name matches %{name}.spec
OK: package seems to meet packaging guidelines
NOT OK: license in specfile matches actual license and meets licensing
guidelines
OK: license file is included in %doc
OK: specfile is written in AE
OK: specfile is legible
OK: sourcefile in the package is the same as provided in the mentioned source,
    md5sum fits
OK: package compiles successfully
OK: all build dependencies are listed in BuildRequires
N/A: package handles locales properly
     there are no locales installed with this package
N/A: call ldconfig in %post and %postun
     the installed binary is not linked against any library
OK: package is not designed to be relocatable
OK: package owns directorys it creates
OK: does not list a file more than once in the %files listing
OK: %files section includes %defattr and permissions are set properly
OK: %clean section is there and contains rm -rf %{buildroot}
OK: macros are consistently used
OK: package contains code
N/A: subpackage for large documentation files
     there are no large documentation files
OK: program runs properly without files listed in %doc
N/A: header files are in a -devel package
     there are no header files
N/A: static libraries are in a -static package
     there are no static libs
N/A: require pkgconfig if package contains a pkgconfig(.pc)
     there is no pkgconfig file
N/A: put .so-files into -devel package if there are library files with suffix
     there isn't any library installed with this package
N/A: devel package includes fully versioned dependency for the base package
     there is no devel package
N/A: any libtool archives are removed
     there are no libtool archives
NOT OK: contains desktop file if it is a GUI application
     this package actually provides GUI, but there is no desktop-file
OK: package does not own any files or directories owned by other packages
OK: buildroot is removed at beginning of %install
N/A: filenames are encoded in UTF-8
     not necessary since there are no non-ASCII filenames


SHOULD
------
N/A: non-English translations for description and summary
     a localization is not available for this package
OK: package builds in mock
OK: package builds into binary rpms for all supported architectures
OK: program runs
N/A: subpackages contain fully versioned dependency for the base package
     there are no subpackages
N/A: pkgconfig file is placed in a devel package
     there is no pkgconfig file
N/A: require package providing a file instead of the file itself
     no files outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin are required

Please update the License-Filed in specfile accordingly to what you wrote
before
to GPLv3+ and contact upstream regarding the license issue in the *.svg-files.
There also is no licensing hint in the sourcefile (gtrayicon.c) itself, so you
may want to suggest upstream to fix that.

A desktop-file seems to be missing. This obviously is a GUI application, how is
it intended to be started without an item in a menu? If necessary, please add
the desktop-file.

As Martin already said, since RPM applies compression for the manpage itself,
you also should consider to apply his suggestion to modify the %build and
%install section.

Once these three issues are fixed or clarified I will approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.