[Bug 528892] Review Request: mingw32-freeglut - Fedora MinGW alternative to the OpenGL Utility Toolkit (GLUT)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528892


Paulo Roma Cavalcanti <promac at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #14 from Paulo Roma Cavalcanti <promac at gmail.com>  2009-10-18 08:32:24 EDT ---
I think I got it.

freeglut does not work when using a windows guest on a Fedora VirtualBox
(3.0.8) host, when 3D acceleration is ENABLED. Disabling 3D acceleration brings
everything back to normal, but depending on the application, it can become very
slow. It does not matter whether the application is cross-compiled or not.

In a native windows, freeglut works as long as glut 3.7 is out of the way.

This is my review:

rpmlint produces some warnings, but according to the mingw guidelines,
all of them are acceptable:

http://fedoraproject.org/wiki/Packaging/MinGW


rpmlint mingw32-freeglut

mingw32-freeglut.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libglut.dll.a
mingw32-freeglut.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/GL/glut.h
mingw32-freeglut.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/GL/freeglut_std.h
mingw32-freeglut.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/GL/freeglut.h
mingw32-freeglut.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/GL/freeglut_ext.h
mingw32-freeglut.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/lib/libglut.dll.a
mingw32-freeglut.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libglut.dll.a
mingw32-freeglut.noarch: W: non-standard-dir-in-usr i686-pc-mingw32
1 packages and 0 specfiles checked; 1 errors, 7 warnings.

--------------------------------------------------------------

1) Track Fedora native package versions
   OK: 2.4.0 in F11 and 2.6.0 in F12

2) Follow Fedora policy
   OK.

3) Package naming
   Packages should be named by prefixing the upstream package name with 
   mingw32-

   OK: Used mingw32-freeglut

4) Base packages
   Not applicable.

5) Filenames of the cross-compilers and binutils
   Not applicable.

6) Naming of the root filesystem
   OK.

7) Standard mingw RPM macros
   OK: Used the standard macros. 

8) Dependencies
   OK.

   BuildRequires:  mingw32-filesystem >= 35
   BuildRequires:  mingw32-gcc
   BuildRequires:  mingw32-binutils

9) Build architecture
   OK: noarch.

10) Libraries (DLLs)
   OK: All libraries built as DLLs. 

11) Do not use %{_mingw32_bindir}/* or %{_mingw32_libdir}/* in %files section
   Not used.

12) Manpages and info files
   None.

13) Static libraries
   None.

14) Stripping
  %global __strip %{_mingw32_strip}
  %global __objdump %{_mingw32_objdump}

  OK: both macros are present in the spec file. 


Package approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.