[Bug 527488] Review Request: drbd - drbd tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #51 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-19 13:14:59 EDT ---
(In reply to comment #50)
> http://people.linbit.com/~florian/drbd-8.3.4-10.src.rpm

- This is 404.

(In reply to comment #48)
> > * BuildRequires
> >   - BR: gcc is redundant:
> >     https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
> 
> I realize that; however I still prefer to list the full build dependencies. The
> packaging guidelines state that the packages are considered "the minimum build
> environment", but if a clueless user happens to run rpmbuild without gcc
> installed, then I consider it proper to fail with an unsatisfied build
> dependency, rather than with a relatively obscure error from configure, midway
> during %prep.

- In your sense not only gcc is affected (glibc-headers, make, tar, 
  redhat-rpm-config.... and so on is also needed) and we don't want
  to write such redundant things. 
  We regard gcc and so on are surely installed, and
  actually we recommend to use mock for clean build, which installs
  gcc automatically.
  Note that not a few users forget to install redhat-rpm-config more
  likely than gcc.

> > * About -rgmanager subpackage
> >   - Is -rgmanager part really needed? From the description in the spec file
> >     currently this subpackage can be rebuilt only for F-10, which is about to
> >     be EOL and on F-11/12/13 this cannot be supported.
> 
> Addressed by Fabio -- see comment #49.

- It is preferable to write such explanation in the spec file
  and file a bug on RH bugzilla so that we can keep track of it.

> > * Duplicate files
> >   - You don't have to include COPYING file as %doc other than -utils
> >     subpackage because all other packages depends on -utils subpackage.  
> 
> Now I have two conflicting reviewer comments. Fabio (in comment #17) tells me
> that all subpackages should contain the COPYING file. Mamoru (in comment #48)
> tells me they shouldn't.
> http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text is
> inconclusive and doesn't mention sub-packages specifically. What should I do?

- You don't have to include a document file which is included in a rpm
  which is required by the rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.