[Bug 509936] Review Request: tortoisehg - Mercurial gui tools and nautilus plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509936


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-19 13:33:46 EDT ---
Well,

* Redundant (Build)Requires
  - "BuildRequires: python" is redundant because python-devel requires
    python.

  - "Requires python >= 2.4" is redundant because python is required by
    pygtk2 and so on, and on supported Fedora branch python is at least
    2.5.2.

  - "Requires: pycairo, pygobject2" is redundant because these are
    required by pygtk2

  - And ">= 2.10" in "Requires: pygtk2" is redundant because on currently
supported
    Fedora pygtk2 is 2.13.0.

! Note:
  - It seems that hgtk is a GUI application. Usually when packaging GUI
    application a corresponding desktop file should be installed altogether:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

    However is seems that hgtk requires at least one argument invoking
    "hgtk" command only does not make sense. So for now I don't request to
    install a desktop file for hgtk.

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on my wiki page:
http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets
(Check "No one is reviewing")

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.