[Bug 522613] Review Request: tornado - Scalable, non-blocking web server and tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522613


Thomas Spura <spurath at students.uni-mainz.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spurath at students.uni-mainz.
                   |                            |de
         AssignedTo|nobody at fedoraproject.org    |spurath at students.uni-mainz.
                   |                            |de
               Flag|                            |fedora-review?




--- Comment #4 from Thomas Spura <spurath at students.uni-mainz.de>  2009-10-19 17:32:32 EDT ---
(In reply to comment #3)
> Inspired by Silas Sewell above, I would also like to rename this package to
> python-tornado.  

Good. Go ahead. :)

Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [?] Package is named according to the Package Naming Guidelines.
     When the name will be python-tornado and the spec renamed, yes
 [?] Spec file name must match the base package %{name}, in the format
%{name}.spec.
     also checking later
 [x] Package meets the Packaging Guidelines
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: 
       [] devel/i386 
       [] devel/x86_64
       [] F11/i386 
       [x] F11/x86_64
 [x] Rpmlint output:
     $ rpmlint tornado.spec tornado-0.2-1.fc11.src.rpm
noarch/tornado-0.2-1.fc11.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

 [x] Buildroot is correct
     (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: ASL 2.0
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     Upstream source: 4704cbf8baab2562c1e648c76de87b60
     Build source:    4704cbf8baab2562c1e648c76de87b60
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
     BuildRequires: python-setuptools is missing, so it should not build in
koji, but it does:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1755511
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
     But: find demos -name "*.py" | xargs chmod -x
     would be better readable.
 [x] Package has a %clean section, which contains rm -rf %{buildroot}.
 [x] Package consistently uses macros.
 [!] Large documentation files are in a -doc subpackage, if required.
     The demos are 1.1 MB big and the main files, which will be used are 0.2
MB, please put the demos in a -doc subpackage
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [!] Fully versioned dependency in subpackages, if present.
     TBD
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

Python specific musts are fullfiled, too.


=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [!] Package does not include license text files separate from upstream.
     upstream already queried
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1755511
 [x] Package functions as described (no hardware to test with).
     helloworld does ;)
 [x] Scriptlets must be sane, if used.
     comment about permissions above
 [-] The placement of pkgconfig(.pc) files is correct.


____________________


Todo:
- rename to python-tornado (summary of this bug, too)
- split the demos into a -doc subpackage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.