[Bug 529404] Review Request: cvc3 - Validity checker of many-sorted first-order formulas with theories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529404





--- Comment #6 from David A. Wheeler <dwheeler at dwheeler.com>  2009-10-19 18:29:12 EDT ---
I've looked over the new .spec file.  Two small nits:

You'll need to submit the Java patch upstream, and document the date you did
so.  The spec currently says:
 # Fix Java build problems.  This patch has not yet been sent upstream.
 Patch3:         cvc3-java.patch
I know you already knew that. :-)

I would recommend changing this:
 rm -f doc/html/classHash_1_1hash__table__inherit__graph.png
to something like:
 badfile="doc/html/classHash_1_1hash__table__inherit__graph.png"
 if [ -f "$badfile" -a ! -s "$badfile" ] ; then
   rm -f "$badfile"
 fi
That way, if future doxygens are changed to handle this graph, re-building the
package will make it work automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.