[Bug 527488] Review Request: drbd - drbd tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #54 from Fabio Massimo Di Nitto <fdinitto at redhat.com>  2009-10-20 13:31:56 EDT ---
(In reply to comment #53)
> For -10:
> 
> * Source tarball
>   - in your srpm differs from what I could download from the URL
>     written as Source in your spec:
> ------------------------------------------------------------
> 426483 2009-10-06 22:26 drbd-8.3.4.tar.gz
> 450560 2009-10-20 03:03 drbd-8.3.4-10.src/drbd-8.3.4.tar.gz
> ------------------------------------------------------------

this was discussed in comment #20 and #23.

Upstream is making a commitment to Fedora by fixing spec file generation to
fulfil this review within upstream build and will release a 8.3.5 tarball once
this process is completed.
This is a simple catch22.. process completes, upstream releases 8.3.5 final
with the changes. Upload here a new srpm/spec/url to final tarball, md5sum will
match.

> * %prep <-> %build
>   - Forgot to mention that we usually write %configure in
>     %build, not in %prep.

Question for me, not relevant to the review, is there a specific policy that
enforce %configure to be invoked only at %build time?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.