[Bug 525192] Review Request: python-mpmath - A pure Python library for multiprecision floating-point arithmetic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525192





--- Comment #17 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-10-20 18:16:05 EDT ---
(In reply to comment #16)
>  [!] Rpmlint output:
> $ rpmlint python-mpmath.spec python-mpmath-0.13-4.fc11.src.rpm
> noarch/python-mpmath-*
> python-mpmath.noarch: W: incoherent-version-in-changelog 0.13-3 ['0.13-4.fc11',
> '0.13-4']
> 3 packages and 1 specfiles checked; 0 errors, 1 warnings.

fixed.

>  [?] License field in the package spec file matches the actual license.
>      License type: New BSD
>      rpmlint accepts this one, too, I'd write this one into it...

"New BSD" is not a valid license tag in Fedora, see
http://fedoraproject.org/wiki/Licensing#Good_Licenses
(BSD is the new license, BSD with advertising is the old 4-clause version that
is GPL incompatible)

>  [!] Fully versioned dependency in subpackages, if present.
>     missing in -doc subpackage

The -doc package has no functional dependencies on python-mpmath. Added anyway.

> - It would be nice, if you would put the mpmath/tests subdir into a subpackage,
> as they are mostly not needed. That would reduce the size of the package about
> 1/3 (unpacked).

I'm not going to do this, since I would need to be 100% sure that it won't
break anything. (I wonder why upstream wants to install the tests in the python
library directory...)

> - The two missing pictures mentioned above are accepable. When running the
> examples by oneself, excatly that windows are opened, so no loss of
> functionality or documentation.  

.. and as you noted in comment #15 this is really just a bug in the upstream
release that will be fixed in the next release.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/python-mpmath.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/python-mpmath-0.13-5.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.