[Bug 527488] Review Request: drbd - drbd tools

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 21 07:58:46 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #56 from LINBIT <partner at linbit.com>  2009-10-21 03:58:43 EDT ---
A fresh iteration of the spec is here:

http://people.linbit.com/~florian/drbd.spec
http://people.linbit.com/~florian/drbd-8.3.4-11.src.rpm

* The license file has been removed from the subpackages dependent on
drbd-utils.

* BuildRequires now only contains flex (and udev, unless invoked with --without
udev, see comment #20)

* Unnecessary %defattr has been removed.

* %{?dist} has been removed from E-V-R in %changelog.

The %configure invocation is still unchanged (left in %prep) pending your
feedback to Fabio's and my comments.

The "service drbd status" issue is also unchanged for the time being, but will
be fixed either in the init script itself, or in the binary that the init
script invokes. Since you said this was not a blocker, I guess the review can
continue in parallel to this being fixed.

Koji builds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1758850 (f12)
http://koji.fedoraproject.org/koji/taskinfo?taskID=1758855 (f13)

Changelog:
859be71... drbd.spec.in: remove COPYING file from subpackages other than -utils
0d9258e... configure.ac, drbd.spec.in: generate BuildRequires from autoconf
14f3c3d... drbd.spec.in: remove superfluous %defattr
de045ed... Spec files: remove optional %{dist} tag from changelog
5efac56... RPM spec files: bump release number

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list