[Bug 526126] Review Request: python3 - Python 3.x (backwards incompatible version)

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 22 23:43:26 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526126





--- Comment #29 from Dave Malcolm <dmalcolm at redhat.com>  2009-10-22 19:43:24 EDT ---
(In reply to comment #26)
> Dave, I've downloaded your new specfile and taken a look at it.
> 
> 1) I love the description for __os_install_post.  It explains the problem
> clearly and is very helpful
Thanks.

I want to build up a full python 3 stack, and a problem is that every
python3-foo module package will need to have a similar construction, and this
could get messy fast.  So this probably needs fixing in rpmbuild, fixing things
so that the /usr/lib/rpm/brp-python-bytecompile script can somehow be told
which python implementation to use (it can accept an argument, but that's not
how it's getting invoked).  Perhaps an environment variable can be used? 
"RPMBUILD_PYTHON_INTERPRETER", or somesuch?

> 2) Are there any of our changes that should be submitted upstream?  For
> example, the iconv command on line 280 seems like something that should be
> fixed upstream.  The same is true for the chmod on line 255, the find/sed on
> line 277, and the find command on line 292.

Probably.

Unfortunately, the find/sed/chmod is corrupting
  /usr/lib/python3.1/test/test_httpservers.py
due to a line beginning with a shebang embedded deep in the file, which is
causing
  grep -m 1 -q '^#!' ~/rpmbuild/BUILD/Python-3.1.1/Lib/test/test_httpservers.py
to match, and then the "sed" command strips out the first line of the file,
which isn't a shebang line (and thus the file becomes syntactically invalid :-(
)

grep's "-m" option doesn't seem to be quite what's needed here for restricting
the shebang search to the first line in the file; any suggestions on fixing
this?  (I tried using "head -n1 | grep", but am unsure of the correct way to
embed that in the "find -exec" clause.

> 3) The %description probably shouldn't refer to Python 3000, since that was
> just a code name and hasn't been used recently.  I would recommend rephrasing
> to "Python 3 is a new version of...".
Sounds good

> I think you're making great progress.  This spec file is looking better and
> better all the time.  
Thanks!  FWIW I think the biggest remaining issue will be to figure out a sane
way of building out a python3- stack on top of this package, which will involve
thinking through packaging practices/guidelines (and probably just trying it
for some packages).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list