[Bug 529861] Review Request: userspace-rcu - RCU (read-copy-update) in user space

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 26 16:10:25 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529861





--- Comment #2 from Jan "Yenya" Kasprzak <kas at fi.muni.cz>  2009-10-26 12:10:23 EDT ---
Thanks for the review. I did the following:
- changed the license to LGPLv2+ (my rpmlint-0.91-1.fc11.noarch did not object
  to the previous value at all)
- added %doc LICENSE to the %files of the main package
  (I am considering moving the %doc README to the -devel package, as the
  information written there is mostly developer oriented)
- added the %check section to run the tests (altough the package does not
  contain a test _suite_ per se, just a bunch of tests without any notion
  of how they should be run).
- as for the shared-lib-calls-exit warning - apparently this is not
  an error, but a design decision of the upstream - they call exit(-1) for
  every fatal error. I am really not sure that trying to change it is the
  task for the packager.

Anyway, the new .spec and .src.rpm files are at the same location (i have kept
the release tag at 1, as the previous attempt was not published anywhere in
Fedora).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list