[Bug 521724] Review Request: perl-Makefile-DOM - Simple DOM parser for Makefiles

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 27 03:50:49 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521724


Ian Weller <ian at ianweller.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #10 from Ian Weller <ian at ianweller.org>  2009-10-26 23:50:47 EDT ---
[  OK  ] source files match upstream:
  2860a83edc7396077716c63f30c12446  Makefile-DOM-0.004.tar.gz
  2860a83edc7396077716c63f30c12446  Makefile-DOM-0.004.tar.gz.1
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  N/A ] license text included in package.
  (not necessary since it's the Perl terms, which are in the perl package)
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  OK  ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
[  OK  ] final provides and requires are sane
[  N/A ] %check is present and all tests pass:
[  OK  ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  N/A ] desktop files valid and installed properly.

this package is APPROVED by me

since kanarip has offered to be a comaintainer and this package is fairly
important I'm going to go ahead and sponsor you. we'll work on the other
package (hyena) this week. be sure to include kanarip in your owners list when
you do the CVS admin procedure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list