[Bug 530275] Review Request: rubygem-erubis - A fast and extensible eRuby implementation

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 29 19:14:13 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530275


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-29 15:14:11 EDT ---
Well,

* About %check:
  - I decided to add the fix for test_syntax2 on ruby.
    Now for F-13/12/11 the fixed ruby rpms are added into buildroot
    tree (i.e. koji scratch build should success now)
    ( and for F-12 the fixed ruby will be pushed on the next
    rawhide push ). So you can remove test_syntax2 hack.

  - The following may be smarter:
------------------------------------------------------------
export GEM_PATH=$(pwd)/%{gemdir}
export PATH=$(pwd)/%{gemdir}/bin:$PATH

pushd .%{geminstdir}/test
find data/users-guide -type f -name \*.rb | \
 xargs sed -i -e '/require.*erubis/i\require "rubygems"'

mv data/users-guide/Example.ejava data/users-guide/example.ejava
ruby -rrubygems test.rb
------------------------------------------------------------
    By the way the line "mv data/...." should be moved to %build
    section because for this file the filename is definitely
    wrong and it is better that the installed file should also
    be renamed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list