[Bug 528010] Review Request: PyMca - GUI for multi-channel analyser spectra visualization and analysis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528010


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org




--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org>  2009-10-30 11:21:18 EDT ---
Just a few comments for now:

- Don't you want to name it PyMCA?

- BR: python-setuptools-devel is not needed, python-setuptools is enought.

- get rid of /usr/bin/env:
find %{buildroot}%{python_sitearch}/PyMca -name '*.py' | xargs sed -i
'/\/usr\/bin\/env/d'
is much less noisy, than your for loop and 'seems' to act faster, but your
choice ;). The for loop is just necessary, if you want to keep timestamps…
Hmm, why don't you?

- What do you want to archieve with 'echo yes' in %build and %install?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.