[Bug 459872] Review Request: asn1c - Free, open source compiler of ASN.1 specifications into C source code

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 30 22:04:36 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459872





--- Comment #11 from Mads Kiilerich <mads at kiilerich.com>  2009-10-30 18:04:34 EDT ---
(In reply to comment #10)
> I believe, I read, that, when you are not allowd to redistribute it, you are
> not allowed to put it in the source tar.gz for uploading and not just deleting
> in %install or %build.

rrc.asn1 isn't in upstreams tar.gz and apparently never was. (But it was in
upstream svn trunk and Peter had included it as an extra source in early specs.
He never deleted it in %install or %build; he just stopped adding it.) 

samples/sample.source.RRC/README is pretty clear.

> Furthermore, if just deleting
> 
> %check
> make check
> 
> fails.
> 
> (You should add this into the spec file, too.)  

Are you saying that %check section is mandatory? That is new to me. AFAICS most
specs don't have a %check section. Can you give a reference?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list