[Bug 532057] Review Request: eclipse-jgit - Eclipse JGit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532057





--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com>  2009-10-31 18:01:03 EDT ---
(In reply to comment #1)
> Issues:
> 
> * First, and most important - I don't know too much about eclipse plugins, but
> I'm sure, that using %{_libdir} in spec-file renders package to be
> arch-dependent. So, I believe, that either noarch should be removed, or
> "%define eclipse_base   %{_libdir}/eclipse" should be fixed to not contain
> %{_libdir}.
> 
> * Naming scheme is somewhat wrong. Instead of "Release:       
> 0.git20091029.1%{?dist}" it should be
> 
> Release:        0.1.git20091029%{?dist}
> 
> Other things looks sane.  

%{_libdir} is used only at buildtime and it is used so we can use scripts from
arch dependent package. It has nothing to do with the noarch type of the
package because I'm neither doing some linking, symlinking or whatever else
from %{_libdir} nor I'm installing something in %{_libdir}.
You can see the guidelines
http://fedoraproject.org/wiki/Packaging/EclipsePlugins where it explained in
details. It is well working for a almost every eclipse plugin included in
Fedora so  I don't see it is a problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.