[Bug 520563] Review Request: rgmanager - Open Source HA Resource Group Failover for Red Hat Cluster

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520563


Andrew Beekhof <andrew at beekhof.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




--- Comment #2 from Andrew Beekhof <andrew at beekhof.net>  2009-09-01 03:31:36 EDT ---
Pretty straight forward... 

[beekhof at ppc ~]$ rpmlint /var/lib/mock/fedora-rawhide-ppc64/result/*.rpm
rgmanager.spec 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

Review:

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPLv2+ and LGPLv2+)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum (spec based on pre-release tarball).
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install.

OK - Package compiles and builds on at least one arch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1647332
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs.
OK - Should have dist tag.
OK - Should package latest version.
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin.

Good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.