[Bug 517859] Review Request: vmpsd - vmpsd is a GPL implementation of Cisco Systems' VMPS

bugzilla at redhat.com bugzilla at redhat.com
Fri Sep 4 17:34:20 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517859





--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-09-04 13:34:19 EDT ---
For -3:

* initscript treatment
  - Still Requires(post) or so are missing:
   
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_spec_file_scriptlets
    ( See Requires(post) or so item )

  - Again usually service should not be enabled by default.
    https://fedoraproject.org/wiki/Packaging/SysVInitScript#.23_chkconfig:_line
    chkconfig line in vmpsd.init should be:
--------------------------------------------------------------------
# chkconfig: - 92 8
--------------------------------------------------------------------

  - And would you check if "condrestart" is not neeeded?

* SourceURL
  - For sourceforge.net hosted source tarball, please see:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

* %clean section
  - I recommend to write %clean section after %install section.

* make
  - On %build section, "make" is enough, "DESTDIR=$RPM_BUILD_ROOT" is not
needed
    ( DESTDIR=foo is needed for "make install" )

  ! Again please add %{?_smp_mflags} if possible:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

* Specifying user/group with "install" command
  - cannot be done as usually rpmbuild is done as non-previledged user.
    So in rpmbuild "-o root -g root" with install fails, this is simply
    not needed.

* Macros
  - Please use macros even in %files section

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list