[Bug 481030] Review Request: emacs-pmd - an interface to PMD for (X)Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481030


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-09-07 11:44:59 EDT ---
Whoops, this slipped under my radar.

**

License is OK
Source matches upstream
Spec conforms to Emacs guidelines
Time stamps are kept

**

I find it a bit of an overkill to use wildcards for a single file, so I'd
replace e.g.
 %{emacs_lispdir}/%{pkg}/*.elc
 %{emacs_startdir}/*.el
 %dir %{emacs_lispdir}/%{pkg}
with
 %{emacs_startdir}/%{pkg}.el
 %dir %{emacs_lispdir}/%{pkg}
 %{emacs_lispdir}/%{pkg}/%{pkg}.elc
(it's more logical to have the dir before its contents on the list).

With this note the package is

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.