[Bug 475065] Review Request: givaro - C++ library for arithmetic and algebraic computations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475065


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de




--- Comment #24 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-08 04:20:41 EDT ---
Since you've already done a good job bringing this package in shape, there
isn't much left to do. If nobody else wants to do the re-review, I can do it
later today.
However, I'm not quite happy with the call of exit() in a shared library. This
is simply bad style and should be avoided by all means. I'm not sure about
Fedora's policy about this, though. 
Here is a patch that replaces the call of exit() by throwing an exception: 
http://mgieseki.fedorapeople.org/givaro/givaro-exit.patch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.