[Bug 225302] Merge Review: automake

bugzilla at redhat.com bugzilla at redhat.com
Wed Sep 9 13:01:30 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225302


Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at city-fan.org




--- Comment #7 from Paul Howarth <paul at city-fan.org>  2009-09-09 09:01:28 EDT ---
Here's a IMHO neater method of fixing the perl requires/provides that doesn't
involve turning off the automatic dependency generator or requiring out-of-spec
scripts:

Index: automake.spec
===================================================================
RCS file: /cvs/pkgs/rpms/automake/devel/automake.spec,v
retrieving revision 1.44
diff -r1.44 automake.spec
10,11d9
< Source1:    filter-provides-automake.sh
< Source2:    filter-requires-automake.sh
22,25d19
< %define _use_internal_dependency_generator 0
< %define __find_provides %{SOURCE1}
< %define __find_requires %{SOURCE2}
< 
37a32,37
> # Kludge to remove bogus Automake perl dependencies and provides
> %global reqfilt /bin/sh -c "%{__perl_requires} | grep -Fv 'perl(Automake::'"
> %define __perl_requires %{reqfilt}
> %global provfilt /bin/sh -c "%{__perl_provides} | grep -Fv 'perl(Automake::'"
> %define __perl_provides %{provfilt}
> 

It also has the beneficial side effect of fixing this rpmlint warning:
automake.src: W: strange-permission filter-requires-automake.sh 0775
automake.src: W: strange-permission filter-provides-automake.sh 0775

As for this:
automake.noarch: W: devel-file-in-non-devel-package
/usr/share/automake-1.11/ansi2knr.c

Since automake is itself a developer tool, this can safely be ignored.

Which parts of automake are MIT licensed?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the Fedora-package-review mailing list