[Bug 517858] Review Request: RackTables - RackTables is a datacenter asset management system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517858





--- Comment #10 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-09-10 13:00:29 EDT ---
For -5:

? Duplicate files
  - I noticed that 4 document files "COPYING LICENSE ChangeLog README"
    are installed under both /usr/share/RackTables and 
    /usr/share/doc/RackTables-0.17.4 .

    Would you check if 4 document files under /usr/share/RackTables
    are needed? (If needed, you don't have to remove these files).

* About %{_sysconfdir}/%{name}/secret.php
  - The directory %{_sysconfdir}/%{name} is not owned by any packages,
    which must be owned by this package.

  - Is the permission/owner/group of this files okay with
    the current setting (i.e. 0644 permission with (root,root))?

! Note
----------------------------------------------------------
%files
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*
----------------------------------------------------------
  can be simplified with
----------------------------------------------------------
%files
%{_datadir}/%{name}/
----------------------------------------------------------
  The latter form contains the directory %_datadir/%name and all
  files/directories/etc under %_datadir/%name.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.