[Bug 517970] Review Request: lingot-0.7.6 - musical instruments tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517970


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |martin.gieseking at uos.de
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review?




--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-12 02:55:20 EDT ---
Here is my formal review of your package. I didn't find any serious things to
be fixed. Just Requires: gtk2 should be removed as BuildRequires: gtk2-devel is
present.
A wrapper script would be a nice addition but it's not a requirement to me. 


$ rpmlint /var/lib/mock/fedora-11-x86_64/result/lingot-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv2+ according to the source header comments

[+] MUST: The License field in spec file must match the actual license.
[+] MUST: File containing license text must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources must match the upstream source.
    md5 hash is e030c45af43e59521f6207ef5c9c5687

[+] MUST: The package MUST successfully compile and build into binary rpms
    - builds in koji
      https://koji.fedoraproject.org/koji/taskinfo?taskID=1672632

[.] MUST: If the package does not successfully compile,...

[X] MUST: All build dependencies must be listed in BuildRequires.
    - Requires: gtk2 is redundant   

[+] MUST: The spec file MUST handle locales properly. 
    - BuildRequires: gettext present
    - %find_lang present
    - %files -f %{name}.lang used

[.] MUST: Packages which store shared library files,...
    - no shared libs

[.] MUST: If the package is designed to be relocatable, ...
    - not relocatable

[+] MUST: A package must own all directories that it creates. 
[+] MUST: Files must not appear more than once in %files listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: %clean section must contain rm -rf %{buildroot}.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.

[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large docs

[+] MUST: Files in %doc must not affect the runtime of the application.

[.] MUST: Header files must be in a -devel package.
    - no header files

[.] MUST: Static libraries must be in a -static package.
    - no static libs

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
    - no .pc files

[.] MUST: .so files without suffix must go in a -devel package.
    - no shared libs

[.] MUST: devel packages must require the base package.
    - no devel subpackage

[+] MUST: Packages must NOT contain any .la libtool archives.

[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
    - desktop file present
    - properly installed with desktop-file-validate
    - referenced svg file added to pixmaps folder


[+] MUST: Packages must not own files or directories already owned by other
packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.

[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
    - works as expected

[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
    - no scriptlets necessary 

[.] SHOULD: subpackages should require the base package.
    - no subpackages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.