[Bug 516312] Review Request: ueagle-atm-firmware4 - Firmwares for usb adsl modems based on Eagle IV chipset

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516312


Dominik 'Rathann' Mierzejewski <rpm at greysector.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235(FE-Legal)




--- Comment #2 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2009-09-13 08:26:33 EDT ---
A couple of comments after a cursory look:

1. Name: ueagle-atm-firmware4 <- where does it come from? The project name is
uEagle-ATM and the tarball name is ueagle4-data.

2. Summary is inconsistent with description (Eagle IV in summary vs. Eagle
I-III in description).

3. Missing Requires: udev for ownership of /lib/firmware.

4. Unowned directory /lib/firmware/ueagle-atm.

5. Inconsistent macro usage (%{buildroot} vs. $RPM_BUILD_ROOT).

6. cp -rf -p <- surely cp -p is enough?

7. A part of the licence text looks fishy:
[...]
| USER ACKNOWLEDGES AND AGREES THAT THE PURCHASE OR USE OF THIS SOFTWARE WILL
| NOT CREATE OR GIVE GROUNDS FOR A
|  LICENSE BY IMPLICATION, ESTOPPEL, OR OTHERWISE IN ANY INTELLECTUAL
|  PROPERTY RIGHTS (PATENT, COPYRIGHT, TRADE SECRET, MASK WORK, OR OTHER
|  PROPRIETARY RIGHT) EMBODIED IN ANY OTHER IKANOS HARDWARE OR SOFTWARE
|  EITHER SOLELY OR IN COMBINATION WITH THIS SOFTWARE.
[...]
and should be vetted by Fedora Legal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.