[Bug 521639] Review Request: hercstudio - GUI for Hercules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521639





--- Comment #5 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-15 15:25:47 EDT ---
The build requires hercules >= 3.06-4 which is not available yet. Are you
planning to create another hercules release? 

I wasn't able to run hercules-3.0.6-3 in HerculesStudio (see below) but maybe I
simply missed a configuration setting, as I'm not familiar with hercules and
its configuration. :) It works on the command-line though.

The package itself is set up properly. I couldn't find anything to be
corrected.


$ rpmlint /var/lib/mock/fedora-11-x86_64/result/hercstudio-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.

[+] MUST: The spec file name must match the base package %{name}.

[+] MUST: The package must meet the Packaging Guidelines.

[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv3+ according to the source file headers
    - COPYING contains GPLv3 license text

[+] MUST: The License field in the package spec file must match the actual
license.

[+] MUST: COPYING must be included in %doc.

[+] MUST: The spec file must be written in American English.

[+] MUST: The spec file for the package MUST be legible.

[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    - md5 hash of the tarball I've checked out doesn't match those of the
      tarball in the src rpm. However, the content of both files is identical
     (checked with hg diff)

[+] MUST: The package MUST successfully compile and build into binary rpms.
    koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1681013

[.] MUST: If the package does not successfully compile, ...

[+] MUST: All build dependencies must be listed in BuildRequires. 

[.] MUST: The spec file MUST handle locales properly. 
    - no locales

[.] MUST: Packages containing shared library files must call ldconfig in %post
and %postun.
    - no shared libs

[.] MUST: If the package is designed to be relocatable, ...
    - package not relocatable

[.] MUST: A package must own all directories that it creates.
    - doesn't create directories    

[+] MUST: File must not be listed more than once in %files.

[+] MUST: Permissions on files must be set properly.

[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.

[+] MUST: Each package must consistently use macros.

[+] MUST: The package must contain code, or permissable content.

[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large docs

[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
    - %doc only contains file COPYING

[.] MUST: Header files must be in a -devel package.
    - no header files packaged

[.] MUST: Static libraries must be in a -static package.
    - no static libs

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
    - no pkgconfig files

[.] MUST: .so (without suffix) must go in a -devel package.
    - no shared libs

[.] MUST: devel packages must require the base package using a fully versioned
dependency
    - no devel subpackage

[.] MUST: Packages must NOT contain any .la libtool archives.
    - no .la files

[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
    - hercstudio.desktop added as %Source1
    - .desktop file is valid 
    - .desktop file is properly installed with desktop-file-install

[+] MUST: Packages must not own files or directories already owned by other
packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).

[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock 

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    - koji scratch build successful (see above)    

[+] SHOULD: The reviewer should test that the package functions as described.
    - HerculesStudio requires hercules >= 3.06-4 which is not available yet
    - I decreased the dependency to 3.06-3 and installed the package available
in bodhi
    - I wasn't able to get hercules run in HerculesStudio. It terminates with 
      "unable to open DLL dyngui: file not found"

[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
    - no scriptlets needed

[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
    - no subpackages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.