[Bug 520477] Review Request: picprog - Microchip PIC micro-controller serial programmer software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520477


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-09-16 14:04:43 EDT ---
Well,

* ExclusiveArch
  - This package does not build on ppc/ppc64. This is because
    this package contains some codes which really won't work
    on ppc/ppc64.
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1681058

    This spec file needs: "ExclusiveArch: %{ix86} x86_64".

! About Patch1
  - I would rather install man file and binary file manually
    for this package, however I will leave it to you where you
    use patch this patch or not.

* %attr(644,root,root)
  - I would suggest to change the permission explicitly at
    %install stage (if really needed) rather than using
    %attr for this issue like:
---------------------------------------------------------
%install
....
....
chmod 0644 $RPM_BUILD_ROOT%{_mandir}/man1/picprog.1*
---------------------------------------------------------

Anyway this package is rather simple, so:

-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on my wiki page:
http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets
(Check "No one is reviewing")

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.