[Bug 519538] Review Request: clutter-sharp - C#/.NET bindings to Clutter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519538





--- Comment #7 from Christian Krause <chkr at plauener.de>  2009-09-16 16:37:15 EDT ---
Thank you very much for the review.

(In reply to comment #6)
> Ping? There are some small changes that need to be made, otherwise the package
> is OK.  

Sorry for the late response. I came just back from 2 weeks of vacation. ;-)

The new packages can be found here:

Spec URL: http://chkr.fedorapeople.org/review/clutter-sharp.spec
SRPM URL:
http://chkr.fedorapeople.org/review/clutter-sharp-0-0.4.20090828.fc11.src.rpm  

(In reply to comment #5)
> clutter-sharp-devel.x86_64: W: summary-not-capitalized pkgconfig file for
> clutter-sharp
> clutter-sharp-devel.x86_64: W: no-documentation
> 
> The first should probably be fixed. The default spec file has
> 
>   Development files for %{name}
> 
> which could be used. Esp. since we're packaging more than just the .pc file!

Fixed.

> OK build dependencies complete (Koji)
> 
> FAIL on the other hand, runtime dependencies are not complete
> 
>      rpm -q --requires clutter-sharp
> 
>      rpm -e clutter 2>out.txt
>      cat out.txt | grep sharp
> 
>   shows that the dependency on clutter is not picked up; this should be
>   added manually.

Fixed.

>   Also, once clutter-gtk can be enabled (prod the maintainer for an update?)

Unfortunately clutter-gtk is not yet released yet:
http://www.clutter-project.org/sources/clutter-gtk/0.10/ . I'll try to keep
this in mind and create a bug entry for clutter-gtk once 0.10.3 is released.

>   you'd want to Requires: clutter-gtk, and meanwhile, now you want to
>   %exclude %{_libdir}/pkgconfig/clutter-gtk-sharp.pc 

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.