[Bug 516906] Review Request: frePPLe - Free Production Planning Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516906





--- Comment #11 from Johan De Taeye <jdetaeye at users.sourceforge.net>  2009-09-18 06:09:18 EDT ---

An updated version has been uploaded, addressing the rpmlint warnings and other
remarks.

>>Changes look good so far. But.. the URL field should not be removed, 
>>really; it points to the program's homepage and is visible to the user 
>>(try rpm -qi on the produced RPM). Only Source1 needs to be removed as 
>>it's redundant and never referred to.

URL and Source fields are present in the spec file. Source1 is removed.

>>Any idea why they pass on the build server? Might it be that they 
>>terminate with no error if there is no Internet connection, but fail 
>>if there actually is?

The only test connecting to the internet is xml_remote. The others run
completely local.
What distinguish this subset of tests from the others is that they compile a
seperate executable, linking with the frepple shared library. The other tests
are using the frepple executable.
The tests are expected to pass. The tests produce an output file test.out in
their subdirectory. Its contents should explain the cause of the problem - my
guess would be that it's a SH_LIBPATH issue...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.