[Bug 524107] Review Request: qbrew - A Brewing Recipe Calculator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524107





--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-18 08:31:02 EDT ---
I'm not a sponsor but nonetheless some quick comments:

- the license tag must be BSD, as file LICENSE and the source headers mention
the BSD license (two clause variant)

- in %Source0, give the full URL to the tarball

- Since with Fedora 10 it's not necessary to define a BuildRoot as rpm does
this automatically. However, if you want to support older Fedora releases or
EPEL <= 5, you have to define it this way:
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- clear the execute flags of the source files, e.g. by adding 
    find src -type f -exec chmod 0644 {} \;
  to the %prep section

- in %files, replace %defattr(-,root,root) by %defattr(-,root,root,-)

- add the files AUTHORS, ChangeLog, and TODO to %doc

- add the version and revision number to the changelog entry:
  ... <chris.a.st.pierre at gmail.com> - 0.4.1-1


$ rpmlint /var/lib/mock/fedora-11-i386/result/qbrew-*
qbrew.i586: W: incoherent-version-in-changelog chris.a.st.pierre at gmail.com
['0.4.1-1.fc11', '0.4.1-1']
qbrew.i586: W: invalid-license Any permissive
qbrew.src: W: invalid-license Any permissive
qbrew-debuginfo.i586: W: invalid-license Any permissive
qbrew-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/qbrew-0.4.1/src/textprinter.h
qbrew-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/qbrew-0.4.1/src/textprinter.cpp
qbrew-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/qbrew-0.4.1/src/configure.cpp
qbrew-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/qbrew-0.4.1/src/configure.h
qbrew-debuginfo.i586: W: spurious-executable-perm
/usr/src/debug/qbrew-0.4.1/src/qbrew.cpp
3 packages and 0 specfiles checked; 0 errors, 9 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.