[Bug 466047] Review Request: tcl-mysqltcl - MySQL interface for Tcl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466047


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #17 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-09-21 14:13:05 EDT ---
Some notes for 3.05-2:

* Source
  - SOURCE0 included in your srpm differs from what I could
    download from the URL written in SOURCE0:
-----------------------------------------------------------
198755 2008-04-06 03:40 mysqltcl-3.05.tar.gz
198617 2008-09-24 08:54 tcl-mysqltcl-3.05-2.fc9.src/mysqltcl-3.05.tar.gz
-----------------------------------------------------------

* License
  - Actually this is "MIT", not "BSD".

* Version specific BuildRequires
  - I don't think there is any sense to write tcl-devel version
    dependency (i.e. >= 8.3.1) where tcl abi dependency is also
    specified.

* Cflags
-----------------------------------------------------------
   139  gcc -pipe -DPACKAGE_NAME=\"mysqltcl\" -DPACKAGE_TARNAME=\"mysqltcl\"
-DPACKAGE_VERSION=\"3.05\" -DPACKAGE_STRING=\"mysqltcl\ 3.05\"
-DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
-DHAVE_LIMITS_H=1 -DHAVE_SYS_PARAM_H=1 -DUSE_THREAD_ALLOC=1 -D_REENTRANT=1
-D_THREAD_SAFE=1 -DTCL_THREADS=1 -D_LARGEFILE64_SOURCE=1
-DTCL_WIDE_INT_TYPE=long\ long -DHAVE_STRUCT_STAT64=1 -DHAVE_OPEN64=1
-DHAVE_LSEEK64=1 -DHAVE_TYPE_OFF64_T=1 -DUSE_TCL_STUBS=1  -I"/usr/include"
-I/usr/include/mysql    -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -O2 -fomit-frame-pointer -Wall -Wno-implicit-int
-fPIC -c `echo ./generic/mysqltcl.c` -o mysqltcl.o
-----------------------------------------------------------
  - "-fomit-frame-pointer" makes debugging very difficult and is
    not allowed on Fedora.

* %defattr
-----------------------------------------------------------
%defattr (0644,root,root,0755)
%doc README ChangeLog COPYING AUTHORS README-msqltcl doc/mysqltcl.html
-----------------------------------------------------------
  - Well, I would recommend to change the permissions of these
    files at %prep explicitly rather than to use this
    %defattr hack.
-----------------------------------------------------------
%defattr (-,root,root)
-----------------------------------------------------------
  - We now recommend %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.