[Bug 523199] Review Request: ncrack - high-speed network authentication cracking tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523199


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review?




--- Comment #11 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-21 14:46:28 EDT ---
The package looks fine now. However, I'm not sure about file ncrack-services
that is placed in /usr/share/ncrack by default. It looks as it could be a
candidate for /etc because it's a kind of configuration file. I'm going to ask
on fedora-devel.


rpmlint /var/lib/mock/fedora-11-x86_64/result/ncrack-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.

[+] MUST: The spec file name must match the base package %{name}.

[X] MUST: The package must meet the Packaging Guidelines.
    - not sure whether /usr/share/ncrack/ncrack-services should go to /etc
      because it's a kind of admin configuration file 

[+] MUST: The package must be licensed with a Fedora approved license.
    - according to source headers GPLv2 with exceptions

[+] MUST: The License field in the package spec file must match the actual
license.

[+] MUST: File containing the text of the license(s) for the package must be
included in %doc.

[+] MUST: The spec file must be written in American English.

[+] MUST: The spec file for the package MUST be legible.

[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    $ sha1sum ncrack-0.01ALPHA.tar.gz*
    797f3274cfab33091330df6425c251c979a8bfb8  ncrack-0.01ALPHA.tar.gz
    797f3274cfab33091330df6425c251c979a8bfb8  ncrack-0.01ALPHA.tar.gz.1


[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    koji scratch build:
    https://koji.fedoraproject.org/koji/taskinfo?taskID=1695351

[.] MUST: If the package does not successfully compile,...
    - package builds for all targets

[+] MUST: All build dependencies must be listed in BuildRequires.

[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
    - no locales

[.] MUST: Packages containing shared library files must call ldconfig in %post
and %postun.
    - no shared libs

[.] MUST: If the package is designed to be relocatable, ...
    - not relocatable

[+] MUST: A package must own all directories that it creates.

[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.

[+] MUST: Permissions on files must be set properly.

[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.

[+] MUST: Each package must consistently use macros.

[+] MUST: The package must contain code, or permissable content.

[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large docs

[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.

[.] MUST: Header files must be in a -devel package.
    - no header files

[.] MUST: Static libraries must be in a -static package.
    - no static libs

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
    - no pkgconfig files

[.] MUST: .so files must go in a -devel package.
    - no shared libs

[.] MUST: devel packages must require the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
    - no devel package

[.] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
    - no .la files

[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file,... 
    - no GUI

[+] MUST: Packages must not own files or directories already owned by other
packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).

[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    - builds in koji

[+] SHOULD: The reviewer should test that the package functions as described.
    - made a short test, seems to work properly    

[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
    - no scriptlets

[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
    - no subpackages

[.] SHOULD: .pc files should be placed in a -devel pkg.
    - no .pc files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.