[Bug 508126] Review Request: education-bookmarks - Education SIG spin bookmarks

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 22 03:51:51 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508126





--- Comment #11 from Mel Chua <mel at redhat.com>  2009-09-21 23:51:50 EDT ---
education-bookmarks.src: E: invalid-spec-name
Fixed: it is now called education-bookmarks.spec

education-bookmarks.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 2)
Fixed: tabs have been replaced with spaces. 

Source0 should be a complete URL.
Fixed: it is.

(I am not sure why "%{_datadir}/bookmarks" is identical to the current files
section - it's definitely shorter -  but this seems to work, so I guess it is
okay.)

Applied to packager group, FAS username mchua.

Rex has been CC'd on the cvsadmin request.

Thanks, Rex, Bjorn, and Sebastian!

http://mchua.fedorapeople.org/packages/education-bookmarks/education-bookmarks.spec
http://mchua.fedorapeople.org/packages/education-bookmarks/education-bookmarks-1-1.fc10.src.rpm
https://fedorahosted.org/education/browser/bookmarks/default-bookmarks.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list