[Bug 524107] Review Request: qbrew - A Brewing Recipe Calculator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524107





--- Comment #8 from Jon Stanley <jonstanley at gmail.com>  2009-09-22 22:30:05 EDT ---
Some other random tidbits:

The upstream tarball includes a stout.qbrew and a paleale.qbrew as example
files of what you can do.  It would be most helpful to include these as %doc as
well.

There's a translation to german in the upstream tarball as well.  It doesn't
seem to build into a .qm even when I extract the tarball and just manually run
./configure ; make - my l10n-fu is non-existent, though. I can reach out for
help on that one if you need it.

This is really nit-picky, but the upstream source files don't have consistent
headers.  Some mention that the license is in the tarball, and others
explicitly spell out what the license is.  The latter is preferred if you can
convince upstream to do that in their next release.  Not a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.