[Bug 509310] Review Request: gpointing-device-settings - Configuration tool for pointing devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509310





--- Comment #16 from Gianluca Sforna <giallu at gmail.com>  2009-09-23 02:44:46 EDT ---
(In reply to comment #15)
> Somehow the spec file differs from the spec file inside the src.rpm. I looks
> like that the standalone spec file contains some more fixes. Please make sure
> that both match in the next update. ;-)

Yeah, I catched some more last minute issues and forgot to reupload the srpm.


> > 
> > DONE (.desktop file adapted from gsynaptic)
> 
> Unfortunately there is an icon referenced ("touchpad") which was only provided
> by the gsynaptic package and so it is missing in the menu entry. Probably we
> can use either another icon provided by one of the base packages or we can add
> the icon from the gsynaptic package as a separate source to this package.
>

icon added from gsynaptics

> Additionally desktop-file-validate complains about some problems:
> desktop-file-validate /usr/share/applications/gpointing-device-settings.desktop
> /usr/share/applications/gpointing-device-settings.desktop: warning: key
> "Encoding" in group "Desktop Entry" is deprecated
> /usr/share/applications/gpointing-device-settings.desktop: warning: value
> "GNOME;Application;Settings;" for key "Categories" in group "Desktop Entry"
> contains a deprecated value "Application"
> 
> 

Both should be OK now.


> You have used:
> Obsoletes:      gsynaptics <= 0.9.17
> IMHO this should be:
> Obsoletes:      gsynaptics < 0.9.17
> (
> http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages

Well, that's just an example, both will work just fine. Anyway, I removed it.

http://giallu.fedorapeople.org/gpointing-device-settings.spec
http://giallu.fedorapeople.org/gpointing-device-settings-1.3.1-4.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.