[Bug 472150] Review Request: coot - crystallographic macromolecular building toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472150





--- Comment #26 from Tim Fenn <fenn at stanford.edu>  2009-09-23 17:44:10 EDT ---
(In reply to comment #25)
> I'm not sure if you think this is ready to be reviewed or not, but I did a
> "quick" build and while there are still 4300+ lines of rpmlint complaints, I
> can ignore all of the shared-lib-calls-exit and undefined-non-weak-symbol
> warnings and get something reasonable.
> 

I've been submitting patches for the non-weak-symbol problems for quite some
time without much upstream action.  I'll ask again.

>   coot.x86_64: W: name-repeated-in-summary Coot
> I suggest s/Coot - t/T/ in the Summary:.
> 

done.

>   coot.x86_64: W: incoherent-version-in-changelog 0.6-20090920svn2334
>    ['0.6-1.20090920svn2334.fc12', '0.6-1.20090920svn2334']
> The release changelog entry is missing a "1.".
> 

oops, fixed.

>   coot.x86_64: E: non-executable-script
>    /usr/lib/python2.6/site-packages/coot/create_server.py 0644 /usr/bin/python
> Is this file supposed to be called by anything?
> 

I checked the code, doesn't seem to be.  I've taken the shebang line out.

>   coot-debuginfo.x86_64: W: spurious-executable-perm
>    /usr/src/debug/coot-0.6/surface/CXXFFTSolventMap.h
>   coot-debuginfo.x86_64: E: script-without-shebang
>    /usr/src/debug/coot-0.6/coot-surface/rgbreps.cc
> Loads of these; the source code really shouldn't be executable.  A quick
> find/chmod should fix it up.
> 

done.

> 
> It looks like the upstream URL has moved.
> 

fixed.

> Otherwise I did a cursory skim over the built packages and everything looks to
> be in place.  I would need to do some testing, but if the above were cleaned up
> and the licensing checks out then I'd say this package would be pretty close to
> ready.  

I've been doing some testing here and noticed the biggest problem is during
startup that some python modules aren't found.  I'll look into this.  And yes,
this package needs testers!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.