[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 24 10:06:29 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525151





--- Comment #6 from Ralf Corsepius <rc040203 at freenet.de>  2009-09-24 06:06:28 EDT ---
(In reply to comment #5)
> SRPM URL:
Thanks.

As you seem to be new to Fedora packaging, let's start with some basic remarks
on your package:

1) Fedora *.spec's are supposed to be named <package>.spec.
You are using <package>-<version>.spec
Please change this.

2) Your *.spec contains hard-coded /usr/bin.
Please use %{_bindir} instead.

3) The compilation being applied by your spec doesn't apply the CFLAGS, all
packages in Fedora are supposed to use.
One way to achieve this with your package is to explicitly set CFLAGS:
make CFLAGS="${RPM_OPT_FLAGS}"

4) You are stripping the application in %install. Fedora applications need to
be built and installed unstripped.
Please remove the "-s" from install.

5) The source files inside of your tarball carry bogus permissions (they are
executable). As you seem to be upstream of the tarball, I'd recommend
"upstream" to fix this in the upstream tarball.
If this should not be applicable, the permissions should be fixed in %build.

Hint: Are you familiar with "rpmlint"? If not, please make yourself familiar
with it - Though this tool is far from being perfect and occasionally produces
bogus warning, it helps avoiding the worst packaging mistakes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list