[Bug 525151] Review Request: CLconverter - A simple command line tool for converting units

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525151





--- Comment #8 from Ralf Corsepius <rc040203 at freenet.de>  2009-09-24 10:47:52 EDT ---
(In reply to comment #7)
>
> 3.I think I've done this because I had to write CFLAGS="${RPM_OPT_FLAGS}" to
> work. When I wrote make CFLAGS="${RPM_OPT_FLAGS}" It would report an error.

make CFLAGS="${RPM_OPT_FLAGS}" CLconverter
would have been it.

> 5.done
You seem to have rebuilt the tarball without incrementing the version.
A reasonable upstream increments the version each time it releases a new
tarball, because people are checking tarballs for changes and will yell at you
when a tarball is being replaced without incrementing the version.

BTW1: Did you consider to add a Makefile to your package? It would help
packagers of various distros and OSes, and assist them to avoid having to
figure out how your package is supposed to be built.

BTW2: Do you have another package on review? Based on this package review
alone, I am not yet sufficiently convinced about your packaging expertise to
sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.