[Bug 524545] Review Request: snacc - Sample Neufeld ASN.1 to C Compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524545





--- Comment #4 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-09-24 11:42:46 EDT ---
#001: move the contents of the -lib subpackage to the main package.
The -lib subpackage is meant for multilibs hence support multiarchitectures. 
IF you want to keep the -lib subpackage you will need to 
1. add a require N-libs-V-R to the base package
2. move the binaries to the -libs package
3. make the base package a noarch

I prefer to eliminate the -lib subpackage entirely.

#002: Documentation:
*.tex and *.bib are pretty useless and inefficient for the user. I propose to
build a PDF out of it in the %prep section and ship only the PDF and not the
sources.

For best practices, all documentations of the same package should be provided
by the same package. This helps the user find the documentation quickly and
efficiently.

#003: Directory ownership in base package 
%dir %{_includedir}/%{name}/

#004: .m4
should this go to -devel ?
%{_datadir}/aclocal/snacc.m4

#005: Patches naming should start with a %{name} prefix, if not they will
overwrite other patches with the same name.

FYI: automake17 is provided by Fedora to maintain compatibility with own
software. The last real update of automake17 on Fedora is back in 2007. It is
recommended for upstream to tune their sources with respect to the newer
versions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.