[Bug 524277] Review Request: dbacl - Digramic Bayesian text classifier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524277


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de




--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de>  2009-09-25 04:39:24 EDT ---
$ rpmlint /var/lib/mock/fedora-11-x86_64/result/dbacl-*
dbacl.x86_64: W: incoherent-version-in-changelog 1.9-2.f11 ['1.9-2.fc11',
'1.9-2']
dbacl.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1
dbacl.x86_64: E: non-executable-script /usr/share/dbacl/doc/prop.pl 0644
/usr/bin/perl
dbacl.x86_64: E: standard-dir-owned-by-package /usr/share/man
3 packages and 0 specfiles checked; 3 errors, 1 warnings.


- according to src/dbcl.h, the license tag must be GPLv2+

- The interactive mode of mailinspect is currently disabled because of the
following missing BRs: ncurses-devel, readline-devel, slang-devel. However, the
sources don't compile without further patching since they seem to rely on an
older version of libslang.

- use macros in the %files section:
  %{_bindir}/*
  %{_mandir}/man1/*

- the documentation is quite extensive, so it's probably a good idea to put it
in a -doc subpackage  

- I'm not sure whether the testsuite must be added. If so, it should probably
go in a separate package.

- add the files AUTHORS, ChangeLog, COPYING, NEWS, README and THANKS to %doc

- remove .f11 from the version numbers in the changelog entries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.