[Bug 524332] Review Request: dualscreen-mouse-utils - Utilities for use with dual head setups using independend screens
bugzilla at redhat.com
bugzilla at redhat.com
Mon Sep 28 09:50:17 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=524332
Stefan Schulze Frielinghaus <stefan at seekline.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stefan at seekline.net
--- Comment #3 from Stefan Schulze Frielinghaus <stefan at seekline.net> 2009-09-28 05:50:15 EDT ---
Review of sha256sum dualscreen-mouse-utils-0.5-2.fc10.src.rpm
80fb0effdea2f5e102f41175cef31eee7ecf20cf39f637660a33a0975be02d7f
[ OK ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
rpmlint /var/lib/mock/fedora-11-ppc/result/dualscreen-mouse-utils-*
dualscreen-mouse-utils.src: E: no-cleaning-of-buildroot %install
dualscreen-mouse-utils.src: E: no-buildroot-tag
3 packages and 0 specfiles checked; 2 errors, 0 warnings.
The two errors can be ignored since they are not required in Fedora 10 an newer
anymore.
[ OK ] MUST: The package must be named according to the Package Naming
Guidelines .
[ OK ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ CHECK ] MUST: The package must meet the Packaging Guidelines .
One small thing left, the Guidelines say to preserve the timestamps
(https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps).
Just use "install -p"
[ OK ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[ OK ] MUST: The License field in the package spec file must match the actual
license.
[ OK ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[ OK ] MUST: The spec file must be written in American English.
[ OK ] MUST: The spec file for the package MUST be legible.
[ OK ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
sha256sum dualscreen-mouse-utils-0.5.tar.gz:
51c94b382e3b32ea8ccbcb3f2ef8972acc68329aec3c4fcaeaf7f55fda166303
[ OK ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ OK ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Build on all architectures. Checked via koji.
[ OK ] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ OK ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ OK ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ OK ] MUST: Packages must NOT bundle copies of system libraries.
[ OK ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ OK ] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
rpmls dualscreen-mouse-utils-0.5-2.fc11.ppc.rpm
-rwxr-xr-x /usr/bin/mouse-switchscreen
-rwxr-xr-x /usr/bin/mouse-wrapscreen
drwxr-xr-x /usr/share/doc/dualscreen-mouse-utils-0.5
-rw-r--r-- /usr/share/doc/dualscreen-mouse-utils-0.5/README
-rw-r--r-- /usr/share/doc/dualscreen-mouse-utils-0.5/gpl.txt
[ OK ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[ OK ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ OK ] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[ OK ] MUST: Each package must consistently use macros.
[ OK ] MUST: The package must contain code, or permissable content.
[ OK ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[ OK ] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[ OK ] MUST: Header files must be in a -devel package.
No headers available.
[ OK ] MUST: Static libraries must be in a -static package.
No libraries available.
[ OK ] MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig' (for directory ownership and usability).
No need for pkgconfig.
[ OK ] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[ OK ] MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[ OK ] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[ OK ] MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section. If you feel that your packaged
GUI application does not need a .desktop file, you must put a comment in the
spec file with your explanation.
Non GUI app in package.
[ OK ] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
[ OK ] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
rpmlint complains about this one too but the guidelines
(https://fedoraproject.org/wiki/Packaging/Guidelines#Prepping_BuildRoot_For_.25install)
say that it is OK for Fedora 10 and later:
"The current redhat-rpm-config package in Fedora 10 and newer automatically
deletes and creates the buildroot at %install, so in Fedora 10 and newer, it is
not necessary for packages to manually Prepare the BuildRoot for install as
described below. Fedora releases older than 10 and EPEL releases older than or
equal to 5 still need to follow the below guidelines."
Therefore I marked this one as OK.
[ OK ] MUST: All filenames in rpm packages must be valid UTF-8.
---------------------------------
[ OK ] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[ N/A ] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[ OK ] SHOULD: The reviewer should test that the package builds in mock.
[ OK ] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
Checked via koji.
[ Not done ] SHOULD: The reviewer should test that the package functions as
described. A package should not segfault instead of running, for example.
[ OK ] SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.
No scriptlets used.
[ OK ] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[ OK ] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,
and this is usually for development purposes, so should be placed in a -devel
pkg. A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb.
[ OK ] SHOULD: If the package has file dependencies outside of /etc, /bin,
/sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
file instead of the file itself.
------------------------------------------
Checked also upstream for newer versions but 0.5 is the latest.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list