[Bug 525786] Review Request: popfile - Automatic Email Classification

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525786





--- Comment #6 from Naoki IIMURA <naoki at getpopfile.org>  2009-09-29 07:19:20 EDT ---
Thanks for another comments.

> Almost okay.

Thank you for reviewing.

> * Documents directory
>   - Usually documents (like "license" text) should be installed
>     under %{_defaultdocdir}/%{name}-%{version}.

OK. I've moved three document files (license and two changelogs) to
the appropriate directory.

>   ! Note
> -------------------------------------------------------------
> %files
> %doc license
> -------------------------------------------------------------
>     will do this automatically.

Thanks for the information.

> * Empty scriptlets
>   - Please remove %pre stage completely. Currently %pre stage
>     essentially does nothing, however leaving this calls
>     unneeded shell process (however Fedora suggests to leave
>     %build stage even if this is empty)

OK. Done.

> * logrotate file
>   - rpmlint says:
> -------------------------------------------------------------
> popfile.noarch: W: log-files-without-logrotate /var/log/popfile
> -------------------------------------------------------------
>     Please consider to create logrotate file (not a blocker).

POPFile has its own log rotation feature.
It checks log directory per hour and removes log file which is older
than three days before.

The new SPEC and SRPM files:
SPEC URL:
http://getpopfile.org/browser/trunk/linux/fedora/popfile.spec?format=raw
SRPM URL: http://getpopfile.org/downloads/popfile-1.1.1-3.fc11.src.rpm

And here's the full changes between release 2 and 3:
http://getpopfile.org/changeset/3620/trunk/linux/fedora/popfile.spec

Naoki

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.