[Bug 550139] Review Request: pino - A fast, easy and free Twitter client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550139


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |cwickert at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |cwickert at fedoraproject.org
               Flag|                            |fedora-review?




--- Comment #4 from Christoph Wickert <cwickert at fedoraproject.org>  2010-01-02 21:10:06 EDT ---
(In reply to comment #1)
> - You need to add 'hicolor-icon-theme' as a requirement to avoid issues with
> the ownership of the %{_datadir}/icons/hicolor directory

Requiring hicolor-icon-theme is not strictly needed because gtk2 already
requires it. It is however recommended.

> - Can you please take a look at your BRs .  Isn't gettext needed by intltool

not on older releases such as EPEL, so I suggest to leave it in.

> The rpmlint output
> 
> [fab at localhost i686]$ rpmlint pino*
> pino-debuginfo.i686: E: debuginfo-without-sources

This one is fixed in with the new package.

(In reply to comment #3)
> - Update to 0.1.0  

Please update to 0.1.1 and then I will review the package. Some more comments:

- Timestamps of both the spec and the source are one year in the future. Please
take care of the timestamps, see 
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

- (Try to) Use Fedoras waf instead of the included version to build the
package.

- %description should be more detailed and end with a dot.

- Don't hardcode /usr in --prefix=/usr. Use the %{_prefix} macro instead, see
http://fedoraproject.org/wiki/Packaging:RPMMacros

- You could use a few more wildcards: Instead of

%{_datadir}/icons/hicolor/scalable/actions/mentions.svg
%{_datadir}/icons/hicolor/scalable/actions/timeline.svg
%{_datadir}/icons/hicolor/scalable/apps/pino.svg
%{_datadir}/icons/hicolor/scalable/apps/pino_fresh.svg

use

%{_datadir}/icons/hicolor/scalable/*/*.svg

But this is minor and up to you. The rest looks fine, package works as
described. Looking forward to see it in Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.